⚙️ Fix broken Docker build by removing non-existent AspireHost project reference #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jongalloway <[email protected]>
Co-authored-by: jongalloway <[email protected]>
Copilot
AI
changed the title
[WIP] ⚙️ Fix broken Docker build
⚙️ Fix broken Docker build by removing non-existent AspireHost project reference
Jun 26, 2025
Copilot finished work on behalf of
jongalloway
June 26, 2025 04:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a broken Docker build by removing an invalid project reference, and adds tests and a helper script to catch similar issues in the future.
- Removed the non-existent AspireHost project COPY line from the Dockerfile
- Added
DockerfileTests.csto verify all.csprojreferences exist and to guard against AspireHost references - Added
test-docker-fix.shto manually validate the Dockerfile copy stage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deployment/docker/Dockerfile | Removed the COPY ["samples/AspireHost/..."] line |
| tests/NLWebNet.Tests/Docker/DockerfileTests.cs | Added MSTest cases to verify referenced project files and ensure no AspireHost reference |
| test-docker-fix.sh | Added a bash script for manual Docker build verification |
Comments suppressed due to low confidence (3)
tests/NLWebNet.Tests/Docker/DockerfileTests.cs:29
- The
projectPathfrom the regex contains forward slashes which may not be recognized on Windows. Consider normalizing separators, e.g.,projectPath = projectPath.Replace('/', Path.DirectorySeparatorChar);before combining paths.
var fullPath = Path.Combine(rootPath, projectPath);
test-docker-fix.sh:1
- Ensure this script is marked executable (e.g.,
chmod +x test-docker-fix.sh) so it can be run directly in CI environments.
#!/bin/bash
test-docker-fix.sh:11
- Using
| head -20truncates the build logs and may hide important failure details. Consider removing| head -20to preserve the full output in CI logs.
docker build -f deployment/docker/Dockerfile --target build --no-cache -t nlwebnet-build-test . 2>&1 | head -20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build was failing with the following error:
The Dockerfile was trying to copy
samples/AspireHost/NLWebNet.AspireHost.csprojbut this file doesn't exist at that path. The actual file is located atsamples/AspireDemo/AspireHost/NLWebNet.AspireHost.csproj.Root Cause
The AspireHost project is part of a separate solution (
samples/AspireDemo/NLWebNet.AspireDemo.sln) and is not included in the main solution (NLWebNet.sln) that the Docker build targets. The Dockerfile is designed to build the Demo application, not the AspireHost project.Solution
Removed the incorrect project reference from the Dockerfile:
# Copy solution file and project files for dependency resolution COPY ["NLWebNet.sln", "./"] COPY ["src/NLWebNet/NLWebNet.csproj", "src/NLWebNet/"] COPY ["samples/Demo/NLWebNet.Demo.csproj", "samples/Demo/"] -COPY ["samples/AspireHost/NLWebNet.AspireHost.csproj", "samples/AspireHost/"] COPY ["tests/NLWebNet.Tests/NLWebNet.Tests.csproj", "tests/NLWebNet.Tests/"]Changes Made
deployment/docker/Dockerfile- Removed the line that copied the non-existent AspireHost project filetests/NLWebNet.Tests/Docker/DockerfileTests.cs- Regression tests to ensure:test-docker-fix.sh- Verification script for manual testingVerification
This is a minimal, surgical fix that removes only the problematic line without affecting the functionality of the Docker build for the Demo application.
Fixes #29.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.